Skip to content

Correctly pass exclude option to JsCodeExtractor #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 1 commit into from
Jul 10, 2018
Merged

Correctly pass exclude option to JsCodeExtractor #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions features/makepot.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,10 @@ Feature: Generate a POT file of a WordPress plugin
<?php
__( 'I am being ignored', 'foo-plugin' );
"""
And a foo-plugin/bar/ignored.js file:
"""
__( 'I am being ignored', 'foo-plugin' );
"""

When I run `wp i18n make-pot foo-plugin foo-plugin.pot --exclude=foo,bar`
Then the foo-plugin.pot file should not contain:
Expand Down
8 changes: 7 additions & 1 deletion src/MakePotCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,13 @@ protected function makepot( $domain ) {
] );

if ( ! $this->skip_js ) {
JsCodeExtractor::fromDirectory( $this->source, $this->translations );
JsCodeExtractor::fromDirectory(
$this->source,
$this->translations,
[
'exclude' => $this->exclude,
]
);
}
} catch ( \Exception $e ) {
WP_CLI::error( $e->getMessage() );
Expand Down