Correctly pass exclude option to JsCodeExtractor#37
Merged
schlessera merged 1 commit intomasterfrom Jul 10, 2018
Merged
Conversation
schlessera
approved these changes
Jul 10, 2018
schlessera
added a commit
that referenced
this pull request
Jan 6, 2022
Correctly pass exclude option to JsCodeExtractor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an oversight after working on #26 and #31 simultaneously.
When fixing the merge conflict for the JS extraction PR, I probably forgot to pass the
excludeoption to the JS scanner as well.Just noticed this after I ran into a timeout trying to extract strings from hundreds of JS files inside
vendor🙃Added a test to make sure JS files are taken into account as well.