Repository navigation
Add wp i18n make-mo command. - #214
Merged
Merged
Conversation
Resolves wp-cli#141.
Member
|
Looks nice at first glance! Thanks for your contribution 🚀 Would you be able to provide some Behat tests for this new command to test the behavior? Let me know if you need help with that. |
Contributor
Author
I added a basic test in 0f954da. |
Also, added a simple test for checking translation.
swissspidy
approved these changes
Jun 3, 2020
schlessera
approved these changes
Jun 4, 2020
Member
|
Great work, @gedex , thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds new i18n command
make-moto generate MO files from PO file(s). Examples:No unit tests added—relies on
Gettext\Translations::toMoFile()that may cover the po-to-mo conversion tests.Resolves #141.