Skip to content

Update expression for dependencies of PHPUnit - #362

Merged
schlessera merged 2 commits into
wp-cli:masterfrom
yukihiko-shinoda:patch-1
May 14, 2021
Merged

schlessera merged 2 commits into
wp-cli:masterfrom
yukihiko-shinoda:patch-1

Conversation

@yukihiko-shinoda

Copy link
Copy Markdown
Contributor

The latest version of WordPress supports PHPUnit 7.x.

@see https://core.trac.wordpress.org/ticket/50482#comment:8
@see https://make.wordpress.org/core/handbook/testing/automated-testing/phpunit/#setup

I checked that my maintaining CI for WordPress plugin works well with WordPress latest and PHPUnit 7.x.
Build #27 - yukihiko-shinoda/staticpress2019 - Travis CI

Comment thread plugin-unit-tests.md Outdated
Comment on lines +29 to +31
* [The latest version of WordPress supports PHPUnit 7.x](https://make.wordpress.org/core/handbook/testing/automated-testing/phpunit/#setup)
* The legacy version of WordPress supported PHPUnit 5.x only when running PHP 7
* The legacy version of WordPress required PHPUnit 4.8 when running PHP 5

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would actually be helpful if the precise WordPress versions were mentioned, like "WordPress 5.5+ (is this correct) supports PHPUnit 7.x".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found Supported Version Chart:
PHPUnit Compatibility and WordPress Versions – Make WordPress Core

Is it better to replace all with link to this page?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that way we don;t have to maintain the exact requirements in here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Replace explanation of support PHPUnit version
with link to Supported Version Chart in WordPress core handbook.
@schlessera schlessera added this to the 2.5.0 milestone May 14, 2021
@schlessera

Copy link
Copy Markdown
Member

Thanks for the PR, @yukihiko-shinoda !

@schlessera
schlessera merged commit 17387e4 into wp-cli:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants