Skip to content

Allow for modern-wordpress redirect; explicit list not search in upgr…#85

Merged
danielbachhuber merged 2 commits intomasterfrom
fix-plugin-install-upgradables-tests
Feb 13, 2018
Merged

Allow for modern-wordpress redirect; explicit list not search in upgr…#85
danielbachhuber merged 2 commits intomasterfrom
fix-plugin-install-upgradables-tests

Conversation

@gitlost
Copy link
Copy Markdown
Contributor

@gitlost gitlost commented Feb 12, 2018

Adjusts plugin slug not matching project name test to allow for redirect (should have https://github.com/wp-cli-test package for this but doing this as a temporary fix so #84 can progress).

Changes upgradables test to check for not installed by listing the item explicitly (probably what was intended originally) rather than searching and being dependent on the vagaries of the wordpress.org api.

@gitlost gitlost added bug scope:testing Related to testing labels Feb 12, 2018
@gitlost gitlost added this to the 1.1.10 milestone Feb 12, 2018
@gitlost
Copy link
Copy Markdown
Contributor Author

gitlost commented Feb 12, 2018

Okay trunk changed to using the info/1.2 api https://core.trac.wordpress.org/ticket/43192. This probably means that this data-specific check CommandWithUpgrade.php#L195 should be adjusted to take account of WP version but for the moment I'll just make the tests agnostic.

@gitlost gitlost requested a review from a team February 12, 2018 23:34
@danielbachhuber danielbachhuber merged commit 5a4bfac into master Feb 13, 2018
@danielbachhuber danielbachhuber deleted the fix-plugin-install-upgradables-tests branch February 13, 2018 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants