Skip to content

Tests: improve Windows compatibility#518

Merged
swissspidy merged 1 commit intomainfrom
fix/windows-tests
Mar 28, 2026
Merged

Tests: improve Windows compatibility#518
swissspidy merged 1 commit intomainfrom
fix/windows-tests

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@github-actions github-actions bot added the scope:testing Related to testing label Mar 27, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test suite by adding a @skip-windows tag to a plugin deletion scenario and changing the quoting style for a remote zip file installation command in the upgradables feature file. I have no further feedback to provide.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 2.3.2 milestone Mar 28, 2026
@swissspidy swissspidy marked this pull request as ready for review March 28, 2026 11:52
@swissspidy swissspidy requested a review from a team as a code owner March 28, 2026 11:52
Copilot AI review requested due to automatic review settings March 28, 2026 11:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Behat feature tests to behave more consistently on Windows environments.

Changes:

  • Quote a complex remote ZIP URL (with & query params) using double-quotes so it is treated as a single argument on Windows shells.
  • Mark a permission-dependent plugin deletion scenario as @skip-windows to avoid running it where filesystem permission semantics differ.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
features/upgradables.feature Adjusts command quoting for a URL with query parameters to avoid Windows shell interpretation issues.
features/plugin-delete.feature Adds a Windows-skip tag to a scenario that relies on Unix-like permission behavior (chmod -w).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@swissspidy swissspidy merged commit 0e4392a into main Mar 28, 2026
68 checks passed
@swissspidy swissspidy deleted the fix/windows-tests branch March 28, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants