Skip to content

Fix visibility in command class methods #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thelovekesh merged 1 commit into from
May 1, 2024
Merged

Fix visibility in command class methods #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/WP_CLI/CommandWithUpgrade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,7 +825,7 @@ private function parse_url_host_component( $url, $component ) {
*
* @return array{ name: string, url: string }|\WP_Error
*/
public function get_the_latest_github_version( $repo_slug ) {
protected function get_the_latest_github_version( $repo_slug ) {
$api_url = sprintf( $this->github_releases_api_endpoint, $repo_slug );
$token = getenv( 'GITHUB_TOKEN' );

Expand Down Expand Up @@ -886,7 +886,7 @@ private function get_asset_url_from_release( $release ) {
*
* @return string|null
*/
public function get_github_repo_from_releases_url( $url ) {
protected function get_github_repo_from_releases_url( $url ) {
preg_match( $this->github_latest_release_url, $url, $matches );

return isset( $matches[1] ) ? $matches[1] : null;
Expand Down