Skip to content

Provide clear error message when plugin fails PHP requirement - #253

Merged
schlessera merged 10 commits into
masterfrom
fix/251-activate-php-requirements
Sep 29, 2020
Merged

schlessera merged 10 commits into
masterfrom
fix/251-activate-php-requirements

Conversation

@schlessera

Copy link
Copy Markdown
Member

If you try to activate a plugin that doesn't meet the minimum PHP requirements, WP-CLI now tells you the specific reason why it is failing, instead of giving a generic error message and then showing a success message as well.

Fixes #251

@schlessera
schlessera requested a review from a team as a code owner August 26, 2020 15:12
@schlessera schlessera added bug command:plugin-activate Related to 'plugin activate' command labels Aug 26, 2020
@schlessera schlessera added this to the 2.0.12 milestone Aug 26, 2020
Comment thread features/plugin-activate.feature Outdated
Comment thread src/Plugin_Command.php Outdated
@schlessera
schlessera merged commit ed5cd65 into master Sep 29, 2020
@schlessera
schlessera deleted the fix/251-activate-php-requirements branch September 29, 2020 05:33
@enrico-atzeni

Copy link
Copy Markdown

Does this also apply to plugins updates made with
wp plugin update <plugin>
in case new version requires a greater PHP version than installed one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:plugin-activate Related to 'plugin activate' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False success and missing explanation when plugin PHP requirement isn't met

3 participants