Repository navigation
Missing --network parameter for plugin is-active - #222
Merged
Merged
Conversation
The code checks for the argument "network" but its possible to add it, since the cli fails because its not declered as a valid param.
schlessera
requested changes
Apr 7, 2020
schlessera
left a comment
schlessera
left a comment
Member
There was a problem hiding this comment.
Good catch!
I just have a tiny nitpick, and then it's good to merge!
add missing dot Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
schlessera
approved these changes
Apr 8, 2020
schlessera
changed the title
--network parameter for plugin is-active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code checks for the argument "network" but its not possible to add it, since the cli fails because its not declered as a valid param.
This fix add's it as a argument.