Skip to content

Don't show a warning when theme delete --all skips the active theme - #218

Merged
schlessera merged 1 commit into
wp-cli:masterfrom
emersonveenstra:issue-217
Mar 12, 2020
Merged

schlessera merged 1 commit into
wp-cli:masterfrom
emersonveenstra:issue-217

Conversation

@emersonveenstra

Copy link
Copy Markdown
Contributor

Fixes issue #217

I'm not sure if only testing on the "Success: Deleted" string is good enough, but i didn't want to assume there will always be 5 themes.

@emersonveenstra
emersonveenstra requested a review from a team as a code owner March 11, 2020 18:24
@schlessera schlessera added bug command:theme-delete Related to 'theme delete' command labels Mar 12, 2020
@schlessera schlessera added this to the 2.0.9 milestone Mar 12, 2020
@schlessera
schlessera merged commit b24df4a into wp-cli:master Mar 12, 2020
@schlessera schlessera changed the title wp theme delete --all no longer errors on active theme deletion Don't show a warning when theme delete --all skips the active theme Mar 12, 2020
@schlessera

Copy link
Copy Markdown
Member

Thanks for the PR, @emersonveenstra !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:theme-delete Related to 'theme delete' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants