Handle extension activation for WP error or extension not found#146
Merged
schlessera merged 5 commits intowp-cli:masterfrom Mar 30, 2019
Merged
Handle extension activation for WP error or extension not found#146schlessera merged 5 commits intowp-cli:masterfrom
schlessera merged 5 commits intowp-cli:masterfrom
Conversation
schlessera
requested changes
Mar 21, 2019
Member
schlessera
left a comment
schlessera
left a comment
There was a problem hiding this comment.
Thanks for the PR, @abhijitrakas!
Can you think of a way to write a test for this change so that we can verify its behavior and guard against regressions?
src/WP_CLI/CommandWithUpgrade.php
Outdated
|
|
||
| if ( $result ) { | ||
| // Check plugin is available or not. | ||
| $plugin = $this->fetcher->get_many( array( $slug ) ); |
Member
There was a problem hiding this comment.
This could just as well be a theme here, so better use the term extension instead:
Suggested change
| $plugin = $this->fetcher->get_many( array( $slug ) ); | |
| $extension = $this->fetcher->get_many( array( $slug ) ); |
src/WP_CLI/CommandWithUpgrade.php
Outdated
| // Check plugin is available or not. | ||
| $plugin = $this->fetcher->get_many( array( $slug ) ); | ||
|
|
||
| if ( ! is_wp_error( $result ) && count( $plugin ) > 0 ) { |
Member
There was a problem hiding this comment.
Suggested change
| if ( ! is_wp_error( $result ) && count( $plugin ) > 0 ) { | |
| if ( ! is_wp_error( $result ) && count( $extension ) > 0 ) { |
Contributor
Author
|
@schlessera PR Updated. Thanks. |
schlessera
added
command:plugin-install
Member
|
Thanks for the PR, @abhijitrakas ! |
schlessera
approved these changes
Mar 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #127