Add --all flag to plugin delete#103
Merged
schlessera merged 3 commits intowp-cli:masterfrom Jul 31, 2018
Merged
Conversation
schlessera
requested changes
Jul 31, 2018
src/Plugin_Command.php
Outdated
|
|
||
| $successes = $errors = 0; | ||
|
|
||
| $plugins = $this->fetcher->get_many( $args ); |
Member
There was a problem hiding this comment.
Lines 967-970 are not needed, this is already covered by the code immediately following.
Just removing these should fix the broken tests.
Member
|
@svenkaptein Thanks for the pull request, and sorry for dropping the ball on this. The tests are currently broken, but a simple removal of superfluous code as hinted at in the review should fix them. As soon as they pass, this is good to be merged. |
Member
|
I'm making the required change myself to add this to the release I'm tagging... |
schlessera
approved these changes
Jul 31, 2018
schlessera
changed the title
--all flag to plugin delete
Member
|
Thanks for the pull-request, @svenkaptein ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first contribution so hopefully everything is OK.
Addressing issue #88