-
Notifications
You must be signed in to change notification settings - Fork 86
Introduce wp theme mod list #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fce7ec0
Added new command
6c2bed7
Add into composer.json
8a500e5
Add behat testing for
27746cd
Add behat testing for 'wp theme mod list'
7e4eda3
Merge branch 'fix-97' of github.com:montu1996/extension-command into …
42f0d9f
change command name and fix small bugs and add proper testcases
d305124
refactor code
8211e8b
Remove array_key_exists()
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,7 +63,8 @@ | |
| "theme path", | ||
| "theme search", | ||
| "theme status", | ||
| "theme update" | ||
| "theme update", | ||
| "theme mod list" | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| Feature: Manage WordPress theme mods list | ||
|
|
||
| Background: | ||
| Given a WP install | ||
| And I run `wp theme mod set key_a value_a` | ||
| And I run `wp theme mod set key_b value_b` | ||
|
|
||
| Scenario: Getting theme mods | ||
| When I run `wp theme mod list` | ||
| Then STDOUT should be a table containing rows: | ||
| | key | value | | ||
|
|
||
| When I run `wp theme mod list --field=key` | ||
| Then STDOUT should be: | ||
| """ | ||
| key_a | ||
| key_b | ||
| """ | ||
|
|
||
| When I run `wp theme mod list --field=value` | ||
| Then STDOUT should be: | ||
| """ | ||
| value_a | ||
| value_b | ||
| """ | ||
|
|
||
| When I run `wp theme mod list --format=json` | ||
| Then STDOUT should be: | ||
| """ | ||
| [{"key":"key_a","value":"value_a"},{"key":"key_b","value":"value_b"}] | ||
| """ | ||
|
|
||
| When I run `wp theme mod list --format=csv` | ||
| Then STDOUT should be: | ||
| """ | ||
| key,value | ||
| key_a,value_a | ||
| key_b,value_b | ||
| """ | ||
|
|
||
| When I run `wp theme mod list --format=yaml` | ||
| Then STDOUT should be: | ||
| """ | ||
| --- | ||
| - | ||
| key: key_a | ||
| value: value_a | ||
| - | ||
| key: key_b | ||
| value: value_b | ||
| """ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests should be written with a list of theme mods that actually contain values, otherwise the tests could just succeed by random chance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use something like this to pre-populate the list:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schlessera Done. can you please check again? 😃