fix/38: trim filename size if it exceeds 99 bytes#92
Closed
Sidsector9 wants to merge 7390 commits intomasterfrom
Closed
fix/38: trim filename size if it exceeds 99 bytes#92Sidsector9 wants to merge 7390 commits intomasterfrom
Sidsector9 wants to merge 7390 commits intomasterfrom
Conversation
Process `--activate` flag on `language install` even if already installed
Actually return `false` when `$widget` is empty
Adapt license header so GitHub picks it up
Improve `wp menu location assign` command
```
Loading composer repositories with package information
Updating dependencies (including require-dev)
- Removing mustangostang/spyc (0.6.1)
- Installing mustangostang/spyc (0.6.2)
Downloading: 100%
- Removing phpunit/php-timer (1.0.8)
- Installing phpunit/php-timer (1.0.9)
Downloading: 100%
Writing lock file
Generating autoload files
```
Before: ``` require: - file1.php - file2.php ``` After: ``` require: - file1.php - file2.php ```
Update Composer dependencies (2/27/2017)
Add missing line break in FeatureContext.php
Introduce `WP_CLI\Utils\basename()` for locale-independent basename()
Abstract `wp import` to a separate wp-cli/import-command package
Per the function comment "Environment values permit specific binaries to be indicated". Currently not possible as PHP_BINARY ***always*** present as defined constant (which can NEVER be overridden unless one uses runkit_extension; dated, not supported)
Like with other commands, info, update, run command, utilize WP_CLI::get_php_binary() in lieu of fixed PHP_BINARY constant.
Fix allowing env. values to permit specific binary
Update tests for WordPress 4.7.3
Abstract `wp db *` to wp-cli/db-command
This prevents adding Composer dependencies with known security vulnerabilities. Resolves #3842
…sories` package. Note: This commit includes additional changes becauase Composer has changed the timestamp format for the lock file.
Add the_title_export and cdata to the WXR format.
Fix category, tag and term names missing in export
Only add needed user when filtering by `--author`
Ensure post attachment meta is exported correctly
schlessera
requested changes
Nov 18, 2021
| /** | ||
| * Remove the extra bytes from the sitename. | ||
| */ | ||
| $sitename = substr( $sitename, 0, ( $sitename_size - $extra_bytes ) ); |
Member
There was a problem hiding this comment.
Using strlen and substr on multibyte strings will lead to corrupted characters, so I assume this will currently not work for titles with multibyte characters in the wrong position.
Member
There was a problem hiding this comment.
This should use the multibyte versions of the string operations if they are available.
Member
|
Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/eee05cd5845f51c91a775b7dfc5b6d2a in case this PR is auto-closed or broken in some way. |
ae975f0 to
4c77acf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #38
This fix trims the title if the size exceeds 99 bytes.