Skip to content

Allow a category ID to be passed in the --category filter.#90

Merged
pento merged 2 commits intomasterfrom
fix/category-id
Oct 5, 2021
Merged

Allow a category ID to be passed in the --category filter.#90
pento merged 2 commits intomasterfrom
fix/category-id

Conversation

@pento
Copy link
Copy Markdown
Member

@pento pento commented Oct 4, 2021

When passing a category ID in the --category filter, the export will fail with the following error message:

Warning: Could not find a category matching 12345.

This PR fixes it by checking if the category is numeric, and casting it to an int.

@pento pento added bug command:export Related to 'export' command labels Oct 4, 2021
@pento pento self-assigned this Oct 4, 2021
@pento pento marked this pull request as ready for review October 4, 2021 23:57
@pento pento requested a review from a team as a code owner October 4, 2021 23:57
Copy link
Copy Markdown
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me 👍

@pento pento changed the title Passing a category ID in --category causes the export to fail. Allow a category ID to be passed in the --category filter. Oct 5, 2021
@pento pento merged commit e810a01 into master Oct 5, 2021
@pento pento deleted the fix/category-id branch October 5, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:export Related to 'export' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants