Use --max_file_size=-1 to avoid splitting export files#12
Use --max_file_size=-1 to avoid splitting export files#12danielbachhuber merged 5 commits intowp-cli:masterfrom
Conversation
drzraf
changed the title
miya0001
left a comment
miya0001
left a comment
There was a problem hiding this comment.
I am feeling -1 is better than 0.
It will be similar with the php.ini.
What do you think about it?
|
Can you add tests too? |
drzraf
force-pushed
the
no-max-file-size
branch
from
0e49deb to
056de53
Compare
|
PR updated (not sure about my new behat's test, couldn't run the tests yet). |
| 0 | ||
| """ | ||
|
|
||
| Scenario: Export spliting the dump |
There was a problem hiding this comment.
This will need Given a WP install to set up the WordPress install.
src/Export_Command.php
Outdated
| } | ||
|
|
||
| $this->max_file_size = $size; | ||
| $this->max_file_size = $size <= 0 ? WP_EXPORT_NO_SPLIT : $size; |
There was a problem hiding this comment.
Let's make -1 the only supported argument to prevent unexpected, undocumented behavior.
There was a problem hiding this comment.
what to do with --max-file-size=0 ?
Isn't a zero or negative value explicit enough to keep from spliting dumps?
|
new commits (don't know if you received notification about this) |
|
@drzraf Is this completed to your satisfaction? |
danielbachhuber
changed the title
|
A problem is that A problem with the tests is that they need a database > 15MB to check the no-split versus the default. I made changes (eventually) to address these in edit |
Okay, I don't know how to do this on this branch, even after reading https://help.github.com/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork/, so I'll open a new PR. |
4 participants
Fixes #8