Support eval-file from stdin (implementation for #19)#21
Merged
schlessera merged 4 commits intowp-cli:masterfrom Feb 21, 2018
pjeby:master
Merged
Support eval-file from stdin (implementation for #19)#21schlessera merged 4 commits intowp-cli:masterfrom pjeby:master
schlessera merged 4 commits intowp-cli:masterfrom
pjeby:master
Conversation
schlessera
requested changes
Feb 20, 2018
src/EvalFile_Command.php
Outdated
| private static function _eval( $file, $args ) { | ||
| include( $file ); | ||
| if ( "-" === $file ) { | ||
| eval( "?>" . file_get_contents("php://stdin")); |
Member
There was a problem hiding this comment.
WPCS: Missing spaces around parentheses, and unnecessary double quote string:
eval( "?>" . file_get_contents( 'php://stdin' ) );
src/EvalFile_Command.php
Outdated
| if ( "-" === $file ) { | ||
| eval( "?>" . file_get_contents("php://stdin")); | ||
| } else { | ||
| include( $file ); |
Member
There was a problem hiding this comment.
No parentheses needed, include is not a function:
include $file;
Note: I know this is only taken from the previous code, but we can fix it anyway while we're making changes here.
README.md
Outdated
|
|
||
| <file> | ||
| The path to the PHP file to execute. | ||
| The path to the PHP file to execute. Use '-' to run code from stdin. |
Member
There was a problem hiding this comment.
We usually refer to STDIN (all caps).
src/EvalFile_Command.php
Outdated
| * | ||
| * <file> | ||
| * : The path to the PHP file to execute. | ||
| * : The path to the PHP file to execute. Use '-' to run code from stdin. |
Member
There was a problem hiding this comment.
We usually refer to STDIN (all caps).
Member
|
Hey @pjeby , |
Contributor
Author
|
Done. |
schlessera
approved these changes
Feb 21, 2018
schlessera
added a commit
that referenced
this pull request
Jan 5, 2022
Support eval-file from stdin (implementation for #19)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per issue #19, this PR implements the ability to
wp eval-filecode fromphp://stdin, using-for consistency with other wp-cli commands that take input from stdin.