Skip to content

Safeguard remove cap from collisions with roles #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 6 commits into from
May 6, 2025
Merged

Safeguard remove cap from collisions with roles #530

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c21ba54
Issue #98 - Added error message when we try to remove capability same…
BhargavBhandari90 Apr 5, 2025
cde87dd
Add behat test for remove-cap improvement
BhargavBhandari90 Apr 9, 2025
6c0b7f6
Improve behat test
BhargavBhandari90 Apr 9, 2025
84f3aa4
Fix behat test failing
BhargavBhandari90 Apr 9, 2025
6ecf307
Provided flag to remove role forcefully
BhargavBhandari90 May 1, 2025
19aa208
Adapt error message
schlessera May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Issue #98 - Added error message when we try to remove capability same… 
… as role
  • Loading branch information
@BhargavBhandari90
BhargavBhandari90 committed Apr 5, 2025
commit c21ba54339d8f88d4e0c5b3a2967892502dae798
4 changes: 4 additions & 0 deletions src/User_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,10 @@ public function remove_cap( $args, $assoc_args ) {
}
WP_CLI::error( "No such '{$cap}' cap for {$user->user_login} ({$user->ID})." );
}
$user_roles = $user->roles;
if ( ! empty( $user_role ) && in_array( $cap, $user_roles, true ) ) {
WP_CLI::error( "There is a role similar to '{$cap}' capability. Use `wp user remove-role` instead." );
}
$user->remove_cap( $cap );

WP_CLI::success( "Removed '{$cap}' cap for {$user->user_login} ({$user->ID})." );
Expand Down