Skip to content

Validate reassign user in user delete command #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 3 commits into from
Mar 5, 2024
Merged

Validate reassign user in user delete command #482

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be8716e
Validate reassign user in user delete command
ernilambar Feb 29, 2024
cb938cc
Split reassign messages
ernilambar Mar 4, 2024
872693d
Avoid DB hit unless `$reassign` is provided
danielbachhuber Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Avoid DB hit unless $reassign is provided
  • Loading branch information
@danielbachhuber
danielbachhuber authored Mar 5, 2024
commit 872693de0b9f5381153338d4bc35b1a8a2cba8bc
2 changes: 1 addition & 1 deletion src/User_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ public function delete( $args, $assoc_args ) {
WP_CLI::error( 'Reassigning content to a different user is not supported on multisite.' );
}

$is_reassign_valid = ( false === get_userdata( $reassign ) ) ? false : true;
$is_reassign_valid = ( $reassign && false === get_userdata( $reassign ) ) ? false : true;

if ( ! $reassign ) {
WP_CLI::confirm( '--reassign parameter not passed. All associated posts will be deleted. Proceed?', $assoc_args );
Expand Down