Skip to content

Add strict/no-strict mode for taxonomy list #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 9 commits into from
Jan 24, 2022
Merged

Add strict/no-strict mode for taxonomy list #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dc5db76
Issue #181 : Add strict/no-strict mode for taxonomy list
buntybuddyboss May 5, 2019
0bec44f
Issue #181 : Remove spaces
buntybuddyboss May 5, 2019
237e627
Issue #181 : Improve logic
buntybuddyboss May 5, 2019
37b2443
Issue #181 : fix phpcs issue
buntybuddyboss May 5, 2019
4cb3fa8
Minor fix
buntybuddyboss May 8, 2019
6412056
Minor fix
buntybuddyboss May 8, 2019
d89f048
Add functional test for strict/no-strict mode for taxonomy
buntybuddyboss May 11, 2019
1087419
Issue #181: Fix coding standerd
buntybuddyboss May 13, 2019
ffedeea
Adapt test for string change in WP 5.1
schlessera Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions features/taxonomy.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,83 @@ Feature: Manage WordPress taxonomies
| Field | Value |
| name | category |
| count | 1 |

@require-wp-5.1
Scenario: Listing taxonomies with strict/no-strict mode
Given a WP installation
And a wp-content/mu-plugins/test-taxonomy-list.php file:
"""
<?php
// Plugin Name: Test Taxonomy Strict/No-Strict Mode

add_action( 'init', function() {
$args = array(
'hierarchical' => true,
'show_ui' => true,
'show_admin_column' => true,
'update_count_callback' => '_update_post_term_count',
'query_var' => true,
'labels' => array(
'name' => _x( 'Genres', 'taxonomy general name', 'textdomain' ),
),

);

register_taxonomy( 'genres', array( 'post','page' ), $args );
} );
"""

When I run `wp taxonomy list --object_type=post --strict`
Then STDOUT should be a table containing rows:
| name | label | description | object_type | show_tagcloud | hierarchical | public |
| category | Categories | | post | 1 | 1 | 1 |
| post_tag | Tags | | post | 1 | | 1 |
| post_format | Formats | | post | | | 1 |

When I run `wp taxonomy list --object_type=post --no-strict`
Then STDOUT should be a table containing rows:
| name | label | description | object_type | show_tagcloud | hierarchical | public |
| category | Categories | | post | 1 | 1 | 1 |
| post_tag | Tags | | post | 1 | | 1 |
| post_format | Formats | | post | | | 1 |
| genres | Genres | | post, page | 1 | 1 | 1 |

@less-than-wp-5.1
Scenario: Listing taxonomies with strict/no-strict mode (for WP < 5.1)
Given a WP installation
And a wp-content/mu-plugins/test-taxonomy-list.php file:
"""
<?php
// Plugin Name: Test Taxonomy Strict/No-Strict Mode

add_action( 'init', function() {
$args = array(
'hierarchical' => true,
'show_ui' => true,
'show_admin_column' => true,
'update_count_callback' => '_update_post_term_count',
'query_var' => true,
'labels' => array(
'name' => _x( 'Genres', 'taxonomy general name', 'textdomain' ),
),

);

register_taxonomy( 'genres', array( 'post','page' ), $args );
} );
"""

When I run `wp taxonomy list --object_type=post --strict`
Then STDOUT should be a table containing rows:
| name | label | description | object_type | show_tagcloud | hierarchical | public |
| category | Categories | | post | 1 | 1 | 1 |
| post_tag | Tags | | post | 1 | | 1 |
| post_format | Format | | post | | | 1 |

When I run `wp taxonomy list --object_type=post --no-strict`
Then STDOUT should be a table containing rows:
| name | label | description | object_type | show_tagcloud | hierarchical | public |
| category | Categories | | post | 1 | 1 | 1 |
| post_tag | Tags | | post | 1 | | 1 |
| post_format | Format | | post | | | 1 |
| genres | Genres | | post, page | 1 | 1 | 1 |
15 changes: 13 additions & 2 deletions src/Taxonomy_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,24 @@ protected function get_counts( $taxonomies ) {
public function list_( $args, $assoc_args ) {
$formatter = $this->get_formatter( $assoc_args );

// Check if it's strict mode or not.
$strict = Utils\get_flag_value( $assoc_args, 'strict', false );

unset( $assoc_args['strict'] );

if ( isset( $assoc_args['object_type'] ) ) {
$assoc_args['object_type'] = array( $assoc_args['object_type'] );
$taxonomy_object = $assoc_args['object_type'];
} else {
$taxonomy_object = get_post_types();
}

$fields = $formatter->fields;
$taxonomies = get_taxonomies( $assoc_args, 'objects' );
$counts = [];
$taxonomies = ( isset( $taxonomy_object ) && ! $strict )
? get_object_taxonomies( $taxonomy_object, 'objects' )
: get_taxonomies( $assoc_args, 'objects' );

$counts = [];

if ( count( $taxonomies ) > 0 && in_array( 'count', $fields, true ) ) {
$counts = $this->get_counts( wp_list_pluck( $taxonomies, 'name' ) );
Expand Down