Add strict/no-strict mode for taxonomy list#256
Conversation
|
What would strict mean here? What issue does it solve? |
|
@swissspidy I am working on this issue: #181 |
swissspidy
changed the title
schlessera
left a comment
schlessera
left a comment
There was a problem hiding this comment.
I added a few comments in-line into the PR for changes to make.
Also, please add one or more functional tests to cover this new flag.
|
Great, code looks good. Can you add one or more functional tests to make sure it also works as expected? |
|
@schlessera . I'll be adding the functional tests over the weekend. Thanks 👍 |
|
@schlessera for this, does it need a check here in FeatureContext ? |
|
Oh, thanks @thrijith, somehow I had looked at the wrong test output here... 🙃 |
|
@schlessera Somehow the test is failing. I am not sure about that. May be it's related to what @thrijith was saying...? |
|
Does the new flag not need to be documented in the function header? |
|
@grappler Yes, indeed! That will be for the next release then, as I just pushed 2.6.0. :) |
6 participants
Added
strictmode for taxonomy list command.Default will be --no-strict
Fixes #181.