Reset option value to default for privacy policy on site empty#236
Merged
danielbachhuber merged 3 commits intowp-cli:masterfrom Mar 4, 2019
thrijith:feature/update-site-empty
Merged
Reset option value to default for privacy policy on site empty#236danielbachhuber merged 3 commits intowp-cli:masterfrom thrijith:feature/update-site-empty
danielbachhuber merged 3 commits intowp-cli:masterfrom
thrijith:feature/update-site-empty
Conversation
danielbachhuber
requested changes
Mar 1, 2019
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Hi @thrijith! Can you include a feature test for this too?
Member
Author
|
Hi @danielbachhuber, I have added a test in an existing scenario. LMK if it's ok. |
danielbachhuber
requested changes
Mar 1, 2019
| Then STDOUT should be: | ||
| """ | ||
| 0 | ||
| """ |
Member
There was a problem hiding this comment.
Can we also include a test that makes sure there's a non-zero value before wp site empty is run?
Member
Author
There was a problem hiding this comment.
I am not sure how to do that, should I create a dummy page and assign it as privacy page?
Member
There was a problem hiding this comment.
should I create a dummy page and assign it as privacy page?
Yes, this would be fine.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wp-cli/wp-cli#5086