Harmonize representation of serialized and JSON-encoded meta values#215
Merged
schlessera merged 7 commits intowp-cli:masterfrom Apr 1, 2019
Merged
Harmonize representation of serialized and JSON-encoded meta values#215schlessera merged 7 commits intowp-cli:masterfrom
schlessera merged 7 commits intowp-cli:masterfrom
Conversation
…ity-command into Issue-wp-cliGH-190
schlessera
changed the title
schlessera
added
command:post-meta-list
Member
|
Thanks for the pull-request, @BhargavBhandari90 ! I'm wondering right now whether we shouldn't consider backward compatibility first before making this change. I don't know how common it is for people to directly use the JSON representation they get from the meta here... I'll bring this up during office hours. |
schlessera
approved these changes
Apr 1, 2019
Member
|
Added a new issue #245 which allows users to switch back to the previous behavior if needed. |
Member
|
Thanks for the PR, @BhargavBhandari90 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #190