Skip to content

Fix tests after Core's introduction of a default "Privacy Policy" page#177

Merged
danielbachhuber merged 4 commits intomasterfrom
176-fix-tests-privacy-policy-page
Apr 17, 2018
Merged

Fix tests after Core's introduction of a default "Privacy Policy" page#177
danielbachhuber merged 4 commits intomasterfrom
176-fix-tests-privacy-policy-page

Conversation

@schlessera
Copy link
Copy Markdown
Member

Fixes #176

@schlessera schlessera added the scope:testing Related to testing label Apr 17, 2018
@schlessera schlessera added this to the 1.3.0 milestone Apr 17, 2018
@schlessera schlessera requested a review from a team April 17, 2018 14:13
We need to fix the tests in such a way that they don't break for everything that is not `trunk`, of course.
@danielbachhuber
Copy link
Copy Markdown
Member

@schlessera Looks like this is still failing? Do the tests need to be dynamic based on WP version?

@schlessera
Copy link
Copy Markdown
Member Author

@danielbachhuber Yes, it is. I quickly realized that I only fixed it for trunk, but we're not dealing with a normal web project targeting a single platform here. So I modified the fix, but lost the internet connection when the plane took off before being able to push.

It should hopefully work on non-trunk as well now. :)

@danielbachhuber danielbachhuber merged commit 92c6937 into master Apr 17, 2018
@danielbachhuber danielbachhuber deleted the 176-fix-tests-privacy-policy-page branch April 17, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants