Add wp site meta sub-command#159
Merged
schlessera merged 41 commits intowp-cli:masterfrom May 28, 2018
spacedmonkey:master
Merged
Add wp site meta sub-command#159schlessera merged 41 commits intowp-cli:masterfrom spacedmonkey:master
schlessera merged 41 commits intowp-cli:masterfrom
spacedmonkey:master
Conversation
schlessera
reviewed
Mar 25, 2018
entity-command.php
Outdated
| WP_CLI::error( 'This is not a multisite installation.' ); | ||
| } | ||
| if ( \WP_CLI\Utils\wp_version_compare( '5.0', '<' ) ) { | ||
| WP_CLI::error( "Requires WordPress 5.0 or greater." ); |
Member
There was a problem hiding this comment.
You'd still need to error out if the WordPress version is not the correct one, i.e. 5.0.
However, you should replace the \WP_CLI\Utils\wp_version_compare( '5.0', '<' ) with the function_exists('is_site_meta_supported') check.
We need to fix the tests in such a way that they don't break for everything that is not `trunk`, of course.
Fix tests after Core's introduction of a default "Privacy Policy" page
Remove duplicative `--user_email=<user-email>` argument
Update scaffolded files
Add `--from-post=<post_id>` flag to create duplicate posts
Abstract meta CRUD into methods
Contributor
Author
|
Now that #174 is merged, I have updated the PR, with overrides that use the @schlessera Can you take a look at this PR again. Quick note, I have rebased my branch, so I could make this change, it has a lot of commit from master in this branch. Sorry about this. |
schlessera
approved these changes
May 28, 2018
Member
|
Thanks for the PR, @spacedmonkey ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the wp site meta sub-command, with tests.
This one is going to be hard to test and might be merge after 5.0.0 is released.
fixes #158