Add subcommand for checking a user's password#144
Merged
gitlost merged 2 commits intowp-cli:masterfrom Feb 13, 2018
thrijith:GH-110
Merged
Add subcommand for checking a user's password#144gitlost merged 2 commits intowp-cli:masterfrom thrijith:GH-110
gitlost merged 2 commits intowp-cli:masterfrom
thrijith:GH-110
Conversation
gitlost
suggested changes
Feb 13, 2018
src/User_Command.php
Outdated
| * ## OPTIONS | ||
| * | ||
| * <user> | ||
| * : The user login or user email of the user to check credentials. |
Contributor
There was a problem hiding this comment.
Should mention ID as well so The user login, user email or user ID of the user to check credentials for.
gitlost
reviewed
Feb 13, 2018
src/User_Command.php
Outdated
| } | ||
|
|
||
| /** | ||
| * Checks if given user credentials are valid or not. |
Contributor
There was a problem hiding this comment.
Actually think this would read better as Checks if a user's credentials are valid or not. (Edit: or maybe Checks if a user's password is valid or not.)
gitlost
approved these changes
Feb 13, 2018
Contributor
|
Thanks @thrijith ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #110
add sub-command to validate user credentials.