Fixes combining chars bug after php-cli-tools safe_substr update.#33
Merged
danielbachhuber merged 1 commit intomasterfrom Aug 4, 2017
Merged
Fixes combining chars bug after php-cli-tools safe_substr update.#33danielbachhuber merged 1 commit intomasterfrom
danielbachhuber merged 1 commit intomasterfrom
Conversation
danielbachhuber
approved these changes
Aug 4, 2017
Member
|
👍 Thanks for picking this up @gitlost |
danielbachhuber
added a commit
that referenced
this pull request
Nov 18, 2022
Fixes combining chars bug after php-cli-tools safe_substr update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After wp-cli/php-cli-tools#118 can now fix the combining chars bug in context here. Also uses
\Xin the non-regex case (whose technique I stole for thepreg_match()part of thesafe_substr()fix btw!).Related failing build in #32