Skip to content

Add/sqlite import export support #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeroenpf wants to merge 22 commits into from
Closed

Add/sqlite import export support #259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
effeac9
Add support for importing into SQLite and exporting from SQLite
jeroenpf Jul 16, 2024
648f5c0
Remove test
jeroenpf Jul 16, 2024
6543dd9
Remove after load
jeroenpf Jul 16, 2024
0c81605
Refactoring changes
jeroenpf Jul 19, 2024
05714cb
Refactoring
jeroenpf Jul 19, 2024
f6b2da6
Some code standard fixes
jeroenpf Jul 19, 2024
963fc04
Ignore some linting issues
jeroenpf Jul 19, 2024
c23bd71
Add namespace to prevent linting error and move noop functions out of…
jeroenpf Jul 23, 2024
a3e359b
Restore after_wp_load that was mistakenly removed
jeroenpf Jul 23, 2024
b10aa9e
Refactoring to ensure behat tests pass
jeroenpf Jul 24, 2024
1d36969
Fix behat tests and prevent them from freezing
jeroenpf Jul 24, 2024
d33bb66
Linter fixes
jeroenpf Jul 24, 2024
74e4008
Check plugin version
jeroenpf Jul 24, 2024
73fb1d3
Import WP_CLI
jeroenpf Jul 25, 2024
377a450
refactoring
jeroenpf Jul 25, 2024
46863b8
Refactoring
jeroenpf Jul 25, 2024
2753c79
Ensure that insert statements appear on one line
jeroenpf Jul 29, 2024
9085b5e
Add comments to the dump
jeroenpf Jul 29, 2024
69dfb06
Remove noop version of apply_filters and do_action
jeroenpf Jul 30, 2024
a9b61e0
Refactor export
jeroenpf Jul 30, 2024
241b89c
Fix outdated behat test
jeroenpf Jul 30, 2024
f9affee
Improve escaping of characters
jeroenpf Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Linter fixes
  • Loading branch information
@jeroenpf
jeroenpf committed Jul 24, 2024
commit d33bb6651a4817259a141ef0bbde7766b7a5286e
4 changes: 1 addition & 3 deletions src/SQLite/Export.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public function run( $result_file, $args ) {
}
}

fwrite( $handle, sprintf( '-- Dump completed on %s', date('c') ) );
fwrite( $handle, sprintf( '-- Dump completed on %s', gmdate( 'c' ) ) );

@adamziel adamziel Aug 2, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwrite() enforces using PHP resource handles. This is a good start, and building on top of that it would be lovely to output that as a simple string for the API consumer to stream-write wherever it needs to. This would play well with the Streaming API I'm exploring for WordPress.

fclose( $handle );

if ( $is_stdout ) {
Expand All @@ -78,8 +78,6 @@ public function run( $result_file, $args ) {
} else {
WP_CLI::success( 'Export complete. File written to ' . $result_file );
}


}

protected function get_create_statement( $table, $translator ) {
Expand Down
5 changes: 3 additions & 2 deletions src/SQLite/Import.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

class Import extends Base {


protected $unsupported_arguments = [
'skip-optimization',
'defaults',
Expand All @@ -26,7 +27,7 @@ public function run( $sql_file_path, $args ) {
$this->load_dependencies();
$translator = new WP_SQLite_Translator();

$is_stdin = '-' === $sql_file_path;
$is_stdin = '-' === $sql_file_path;
$import_file = $is_stdin ? 'php://stdin' : $sql_file_path;

foreach ( $this->parse_statements( $import_file ) as $statement ) {
Expand All @@ -37,7 +38,7 @@ public function run( $sql_file_path, $args ) {
}

$imported_from = $is_stdin ? 'STDIN' : $sql_file_path;
WP_CLI::success( sprintf("Imported from '%s'.", $imported_from ) );
WP_CLI::success( sprintf( "Imported from '%s'.", $imported_from ) );
}

/**
Expand Down