Skip to content

Tests: Use different port numbers between scenarios#139

Merged
swissspidy merged 1 commit intomainfrom
fix/tests-compat
Mar 28, 2026
Merged

Tests: Use different port numbers between scenarios#139
swissspidy merged 1 commit intomainfrom
fix/tests-compat

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the port used for the WP server in the cron feature tests from 8080 to 8081 to avoid conflicts. While this change addresses immediate port collisions, it is recommended to implement dynamic port allocation to further improve test robustness and prevent similar issues in the future.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 2.3.6 milestone Mar 28, 2026
@swissspidy swissspidy marked this pull request as ready for review March 28, 2026 11:39
@swissspidy swissspidy requested a review from a team as a code owner March 28, 2026 11:39
Copilot AI review requested due to automatic review settings March 28, 2026 11:39
@swissspidy swissspidy merged commit d0075fa into main Mar 28, 2026
64 checks passed
@swissspidy swissspidy deleted the fix/tests-compat branch March 28, 2026 11:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the WP-CLI Behat feature tests for cron to avoid port collisions between scenarios that launch wp server in the background.

Changes:

  • Changed the wp server port used in the “Don't trigger cron when ALTERNATE_WP_CRON is defined” scenario from 8080 to 8081.
  • Updated the cron_request URL rewrite in the same scenario to target http://localhost:8081.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants