Tests: Use different port numbers between scenarios#139
Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
There was a problem hiding this comment.
Code Review
This pull request updates the port used for the WP server in the cron feature tests from 8080 to 8081 to avoid conflicts. While this change addresses immediate port collisions, it is recommended to implement dynamic port allocation to further improve test robustness and prevent similar issues in the future.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Updates the WP-CLI Behat feature tests for cron to avoid port collisions between scenarios that launch wp server in the background.
Changes:
- Changed the
wp serverport used in the “Don't trigger cron when ALTERNATE_WP_CRON is defined” scenario from8080to8081. - Updated the
cron_requestURL rewrite in the same scenario to targethttp://localhost:8081.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.