Bring template file from wp-cli#73
Conversation
|
@sasagar Thanks for the pull request (and say hello to everyone at the CLI table in Osaka from me)! The pull request is not correct yet. First of all, the template should go into a Also, regarding pulling in the template via the If you want to work on the You can just copy this and adapt it for the |
utils/make-phar.php
Outdated
| @@ -0,0 +1,2 @@ | |||
| <?php | |||
| include( '../version.mustache' ); | |||
There was a problem hiding this comment.
This is not needed here and should be done in the wp-cli/wp-cli package instead.
| @@ -0,0 +1,4 @@ | |||
| WordPress version: {{wp-version}} | |||
There was a problem hiding this comment.
Please put this file into a templates subfolder to stick with current conventions.
| @@ -0,0 +1,4 @@ | |||
| WordPress version: {{wp-version}} | |||
There was a problem hiding this comment.
Ha, almost!
The folder is called templates (plural), not the singular template.
There was a problem hiding this comment.
Oops, I'd like to change it!
2 participants
Related #72
I'm not sure this PR is enough for the issue, but the test has been passed.
If not, I'm happy to re-commit for that.
(This is my first PR for the code at WordCamp Osaka 2018.)
Thanks.