Skip to content

Adapt package for framework v2#66

Merged
schlessera merged 5 commits intomasterfrom
adapt-for-v2
Aug 4, 2018
Merged

Adapt package for framework v2#66
schlessera merged 5 commits intomasterfrom
adapt-for-v2

Conversation

@schlessera
Copy link
Copy Markdown
Member

Fixes #65

@swissspidy
Copy link
Copy Markdown
Member

The only error seems to be:

Error: Can’t select database. We were able to connect to the database server (which means your username and password is okay) but not able to select the `wp_cli_test` database.

when trying to run wp db create.

The db command doesn't seem to be installed though. Shouldn't the error message be different then?

@schlessera
Copy link
Copy Markdown
Member Author

The nice thing is that the tests are now much more reliable and the failures are reproducible. So, now, a composer behat on local actually produces the same error. I'll investigate. I suppose it is the --verify of the config creation that fails because the db command errors out.

@swissspidy
Copy link
Copy Markdown
Member

Ah makes sense.

I was so close to just require the db command like you just did now :-)

@schlessera
Copy link
Copy Markdown
Member Author

I tested first:

image 2018-08-04 at 3 49 08 pm

@schlessera schlessera added this to the 1.2.1 milestone Aug 4, 2018
@schlessera schlessera merged commit 2468a25 into master Aug 4, 2018
@schlessera schlessera deleted the adapt-for-v2 branch August 4, 2018 15:41
schlessera added a commit that referenced this pull request Jan 6, 2022
Adapt package for framework v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants