Skip to content

Fix library version to ^1.2.1#53

Merged
schlessera merged 2 commits intomasterfrom
force-library-version-121
Apr 19, 2018
Merged

Fix library version to ^1.2.1#53
schlessera merged 2 commits intomasterfrom
force-library-version-121

Conversation

@schlessera
Copy link
Copy Markdown
Member

@schlessera schlessera added bug command:config-set Related to 'config set' command labels Apr 10, 2018
@schlessera schlessera added this to the 1.2.0 milestone Apr 10, 2018
@schlessera schlessera requested a review from a team April 10, 2018 20:01
@danielbachhuber
Copy link
Copy Markdown
Member

What if we instead added wp-cli/wp-config-transformer as a wp-cli/wp-cli dependency and had wp-make-coffee handle it?

And, taking a step back, why is this necessary? Shouldn't Composer install the latest automatically?

@schlessera
Copy link
Copy Markdown
Member Author

schlessera commented Apr 10, 2018

What if we instead added wp-cli/wp-config-transformer as a wp-cli/wp-cli dependency and had wp-make-coffee handle it?

No, I currently try to get away from having the framework depend on command requirements, as we have now with the Symfony dependencies that are actually only needed for the package manager. Related: wp-cli/wp-cli#4748

And, taking a step back, why is this necessary? Shouldn't Composer install the latest automatically?

It is not necessary for our Phar build, but it could avoid bugs for Composer builds where a hard requirement on the bug-fixed version shows errors when you try to use an older one.

@schlessera schlessera merged commit aa24eeb into master Apr 19, 2018
@schlessera schlessera deleted the force-library-version-121 branch April 19, 2018 08:59
schlessera added a commit that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:config-set Related to 'config set' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants