Removed leftover remove() operation#52
Merged
schlessera merged 4 commits intowp-cli:masterfrom Mar 27, 2018
Merged
Conversation
Bugfix 51
schlessera
requested changes
Mar 23, 2018
| } | ||
| } | ||
|
|
||
| $config_transformer->remove( $type, $name ); |
Member
There was a problem hiding this comment.
You've removed the wrong remove.
The one that is superfluous is at https://github.com/wp-cli/config-command/pull/52/files#diff-a3ce20ba86d7a7fcd6d399db066ca679R614
Contributor
Author
There was a problem hiding this comment.
You're right, I see the error in my own remove. Sorry.
Member
There was a problem hiding this comment.
No need to be sorry, it was an easy mistake and that's what code reviews are for.
Member
There was a problem hiding this comment.
@lalaithan Let me know if you have trouble updating this pull request.
Correcting per PR comments
schlessera
approved these changes
Mar 27, 2018
Member
|
Thanks for the pull request, @lalaithan ! |
schlessera
changed the title
remove() operation
schlessera
added a commit
that referenced
this pull request
Jan 6, 2022
Removed leftover remove operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed leftover remove operation mentioned in issue #51