Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Behat feature files to improve cross-platform compatibility by replacing /dev/null with a temporary file and switching from single to double quotes in shell commands. However, the use of double quotes for the password argument in features/config-create.feature introduces a regression on POSIX-compliant systems because the shell will interpret the backslash escape sequences differently than on Windows.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates Behat feature tests for wp config. Key changes include replacing /dev/null redirection with a physical empty.php file, switching from wget to curl for downloading test scripts, and converting single quotes to double quotes in shell commands, which required updates to character escaping for database passwords and editor configurations. I have no feedback to provide as there were no review comments.
There was a problem hiding this comment.
Pull request overview
Updates the Behat feature tests for the config command to behave more consistently across environments, with a focus on Windows-friendly shell usage.
Changes:
- Adjusts shell quoting for
EDITOR=...invocations inwp config editscenarios. - Replaces
/dev/nullSTDIN redirection with an empty fixture file for--extra-phpinput. - Switches the test download step from
wgettocurland updates assertions accordingly; updates password-escaping test cases/expectations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
features/config-edit.feature |
Updates EDITOR quoting in config edit scenarios to avoid shell-quoting issues. |
features/config-create.feature |
Removes /dev/null dependency, updates download mechanism, and refines password escaping test cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.