Skip to content

More flexible soft change checks (issue #34)#41

Closed
phlbnks wants to merge 0 commit intowp-cli:masterfrom
phlbnks:master
Closed

More flexible soft change checks (issue #34)#41
phlbnks wants to merge 0 commit intowp-cli:masterfrom
phlbnks:master

Conversation

@phlbnks
Copy link
Copy Markdown

@phlbnks phlbnks commented Apr 13, 2018

  • case insensitivity in filenames
  • accept .md extension as well as .txt

@phlbnks
Copy link
Copy Markdown
Author

phlbnks commented Apr 13, 2018

Ah - silly error. Any recommendations on how to test this? Is the only way to install another plugin that uses readme.md to test against?

@schlessera
Copy link
Copy Markdown
Member

@emirpprime Yes, you need to use a plugin that actually exhibits the problematic behavior.

You can use the one that triggered the initial issue, it was document-gallery.

@schlessera schlessera added the command:plugin-verify-checksums Related to 'plugin verify-checksums' command label Apr 19, 2018
@schlessera schlessera added this to the 1.0.9 milestone Apr 19, 2018
@schlessera
Copy link
Copy Markdown
Member

@emirpprime You should also merge latest master, which fixes the memory issue with PHP 5.3 tests.

@schlessera
Copy link
Copy Markdown
Member

😳 GitHub, why is this closed now???

I'm sorry, @emirpprime, I was just pushing the update to get the memory fix for PHP 5.3.

Something with the pull-request must have been messed up internally, because I pushed the change into your fork's master, which immediately closed the PR here.

Also I cannot seem to reopen it:
image 2018-04-19 at 5 29 04 pm

If you still care to add this functionality, please open a new PR with your changes. I'm very sorry for wasting your time here.

@schlessera
Copy link
Copy Markdown
Member

For reference, here's a diff of the code:
image 2018-04-19 at 5 34 33 pm

@schlessera
Copy link
Copy Markdown
Member

Continued in #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:plugin-verify-checksums Related to 'plugin verify-checksums' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants