Skip to content

Update warning text during multisite cache flushes#88

Merged
danielbachhuber merged 1 commit intowp-cli:mainfrom
WPprodigy:fix/78-update-cache-flush-warning
Jul 25, 2023
Merged

Update warning text during multisite cache flushes#88
danielbachhuber merged 1 commit intowp-cli:mainfrom
WPprodigy:fix/78-update-cache-flush-warning

Conversation

@WPprodigy
Copy link
Copy Markdown
Contributor

@WPprodigy WPprodigy commented Jul 24, 2023

Update to the text from #86, fixes #78.

Context: Some object cache implementations won't flush the entire network, and the --url= param is still useful. Since WP CLI is still switching context to the site in question, we shouldn't use the "ignoring" verbiage as that isn't truly accurate.

@WPprodigy WPprodigy requested a review from a team as a code owner July 24, 2023 23:21
@danielbachhuber danielbachhuber added command:cache Related to 'cache' command command:cache-flush Related to 'cache flush' command labels Jul 24, 2023
Copy link
Copy Markdown
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@danielbachhuber danielbachhuber added this to the 2.1.1 milestone Jul 25, 2023
@danielbachhuber danielbachhuber merged commit b4726ce into wp-cli:main Jul 25, 2023
@WPprodigy WPprodigy deleted the fix/78-update-cache-flush-warning branch August 15, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:cache Related to 'cache' command command:cache-flush Related to 'cache flush' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn when attempting to flush cache with --url on multisite

2 participants