When flushing cache on a multisite give a warning.#83
Closed
janw-me wants to merge 0 commit intowp-cli:mainfrom
janw-me:main
Closed
When flushing cache on a multisite give a warning.#83janw-me wants to merge 0 commit intowp-cli:mainfrom janw-me:main
janw-me wants to merge 0 commit intowp-cli:mainfrom
janw-me:main
Conversation
src/Cache_Command.php
Outdated
| $value = wp_cache_flush(); | ||
|
|
||
| if ( WP_CLI::has_config( 'url' ) && ! empty( WP_CLI::get_config()['url'] ) && is_multisite() ) { | ||
| WP_CLI::warning( 'You are using a multisite installation. Flushing the cache will flush the cache for all sites.' ); |
Member
There was a problem hiding this comment.
What do you think about a message like this?
Ignoring the
--url=<url>argument because flushing the cache affects all sites on a multisite installation.
I think it's worth explicitly mentioning the cause of the warning message. I also don't know how often we use "You" in messages...
Member
Author
|
@danielbachhuber I agree, the "you" was pretty strange. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache flushes on all sites, not just the current url.
Fixes #78