Merged
Conversation
wojsmol
force-pushed
the
fix/php-8.2-testing
branch
from
4b0ec8d to
3d55c71
Compare
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks!
Out of curiosity, how does this impact the build status?
I'll defer to @schlessera on when we might want to land this. I think we'll want to have some bandwidth to fix any broken bits.
Co-authored-by: Daniel Bachhuber <daniel@bachhuber.co>
Contributor
Author
As long as we have |
schlessera
approved these changes
Jan 3, 2023
Member
|
Yes, this looks good. Running the tests on PHP 8.2 but still continuing on error will mean we don't fail the CI but still collect error info for PHP 8.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43