Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions job display names to make the test suite easier to scan in the Actions UI (distinguishing Unit tests from Behat/functional tests).
Changes:
- Prefix unit-test job names with
Unit | ...in the reusable unit workflow. - Rename functional test job display name from
FunctionaltoBehatin the testing aggregator workflow. - Prefix functional-test job names with
Behat | ...in the reusable functional workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/reusable-unit.yml | Adjusts the unit job display name to include a `Unit |
| .github/workflows/reusable-testing.yml | Renames the functional job display name to Behat. |
| .github/workflows/reusable-functional.yml | Adjusts the functional job display name to include a `Behat |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobs: | ||
| unit: | ||
| name: PHP ${{ inputs.php }}${{ inputs.coverage && ' (with coverage)' || '' }}${{ startsWith( inputs.os, 'windows' ) && ' (Windows)' || '' }}${{ startsWith( inputs.os, 'macos' ) && ' (macOS)' || '' }} | ||
| name: Unit | PHP ${{ inputs.php }}${{ inputs.coverage && ' (with coverage)' || '' }}${{ startsWith( inputs.os, 'windows' ) && ' (Windows)' || '' }}${{ startsWith( inputs.os, 'macos' ) && ' (macOS)' || '' }} |
There was a problem hiding this comment.
Changing the job name: will change the resulting check-run name in GitHub Actions. If branch protection rules, required status checks, or README badges rely on the previous check name, they’ll need to be updated to match the new name.
| name: Unit | PHP ${{ inputs.php }}${{ inputs.coverage && ' (with coverage)' || '' }}${{ startsWith( inputs.os, 'windows' ) && ' (Windows)' || '' }}${{ startsWith( inputs.os, 'macos' ) && ' (macOS)' || '' }} | |
| name: Unit |
| needs: prepare-functional | ||
| if: ${{ needs.prepare-functional.outputs.matrix != '' }} | ||
| name: Functional | ||
| name: Behat |
There was a problem hiding this comment.
Renaming this job from "Functional" to "Behat" changes the check-run name produced by the workflow. If any branch protection required checks, external tooling, or badges reference the old check name, they will need to be updated accordingly.
| name: Behat | |
| name: Functional |
| jobs: | ||
| functional: | ||
| name: PHP ${{ inputs.php }} | WP ${{ inputs.wp }} | ${{ inputs.dbtype == 'sqlite' && 'SQLite' || inputs.dbtype == 'mariadb' && 'MariaDB' || 'MySQL' }}${{ inputs.object_cache == 'sqlite' && ' (Obj Cache)' || '' }}${{ inputs.coverage && ' (with coverage)' || '' }}${{ startsWith( inputs.os, 'windows' ) && ' (Windows)' || '' }}${{ startsWith( inputs.os, 'macos' ) && ' (macOS)' || '' }} | ||
| name: Behat | PHP ${{ inputs.php }} | WP ${{ inputs.wp }} | ${{ inputs.dbtype == 'sqlite' && 'SQLite' || inputs.dbtype == 'mariadb' && 'MariaDB' || 'MySQL' }}${{ inputs.object_cache == 'sqlite' && ' (Obj Cache)' || '' }}${{ inputs.coverage && ' (with coverage)' || '' }}${{ startsWith( inputs.os, 'windows' ) && ' (Windows)' || '' }}${{ startsWith( inputs.os, 'macos' ) && ' (macOS)' || '' }} |
There was a problem hiding this comment.
This job name change will alter the check-run name emitted by this reusable workflow. If any required status checks or integrations depend on the previous name, update them to prevent merges from being blocked.
| name: Behat | PHP ${{ inputs.php }} | WP ${{ inputs.wp }} | ${{ inputs.dbtype == 'sqlite' && 'SQLite' || inputs.dbtype == 'mariadb' && 'MariaDB' || 'MySQL' }}${{ inputs.object_cache == 'sqlite' && ' (Obj Cache)' || '' }}${{ inputs.coverage && ' (with coverage)' || '' }}${{ startsWith( inputs.os, 'windows' ) && ' (Windows)' || '' }}${{ startsWith( inputs.os, 'macos' ) && ' (macOS)' || '' }} | |
| name: Behat functional tests |
No description provided.