Skip to content

Fix crash on list controls #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2020
Merged

Fix crash on list controls #1801

merged 2 commits into from
Jan 22, 2020

Conversation

@etoledom
Copy link
Contributor

@etoledom etoledom commented Jan 22, 2020

This PR updates the Gutenberg ref to test a crash fix described on: WordPress/gutenberg#19818:

The editor crashes when trying to press on the list block controls.

To test:

  • Add a List Block.
  • Press any of the controls (i.e: Change the list type to ordered).
  • Check that it doesn't crash.
  • Check that it works properly.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added this to the 1.21 milestone Jan 22, 2020
@etoledom etoledom requested review from hypest and marecar3 January 22, 2020 16:44
@etoledom etoledom self-assigned this Jan 22, 2020
@etoledom etoledom mentioned this pull request Jan 22, 2020
Merged
marecar3
marecar3 approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@etoledom
Copy link
Contributor Author

etoledom commented Jan 22, 2020

Merging directly since the failing test is a known flaky test.

@etoledom etoledom merged commit 4ae5774 into release/1.21.0 Jan 22, 2020
@etoledom etoledom deleted the issue/fix-crash-on-list-controls branch January 22, 2020 18:05
@hypest hypest mentioned this pull request Jan 23, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hypest hypest Awaiting requested review from hypest

1 more reviewer

@marecar3 marecar3 marecar3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@etoledom etoledom

Labels

bugfix

Projects

None yet

Milestone

1.21

Development

Successfully merging this pull request may close these issues.

3 participants

@etoledom @marecar3