Skip to content

[Reader] Scroll to the top if the tab bar button is tapped - #19769

Merged
twstokes merged 2 commits into
trunkfrom
enhancement/reader-scroll-to-top
Dec 13, 2022
Merged

[Reader] Scroll to the top if the tab bar button is tapped#19769
twstokes merged 2 commits into
trunkfrom
enhancement/reader-scroll-to-top

Conversation

@twstokes

@twstokes twstokes commented Dec 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #17021

Description

This PR scrolls Reader to the top when the tab bar button is tapped.

Testing

  1. In the Jetpack and WordPress apps, load Reader and scroll down some.
  2. Tap the Reader tab bar button at the bottom, in the center.
  3. Expect: Reader to scroll to the top.

Regression Notes

  1. Potential unintended areas of impact

    • This only adds the functionality to ReaderStreamViewControllers. It's possible I missed another type that needs to scroll.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing above.

  3. What automated tests I added (or what prevented me from doing so)

    • None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes added this to the 21.5 milestone Dec 12, 2022
@twstokes twstokes self-assigned this Dec 12, 2022
@twstokes
twstokes marked this pull request as ready for review December 12, 2022 21:17
@twstokes
twstokes requested a review from salimbraksa December 12, 2022 21:20
@wpmobilebot

wpmobilebot commented Dec 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19769-8d4f760 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

wpmobilebot commented Dec 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19769-8d4f760 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

salimbraksa
salimbraksa approved these changes Dec 13, 2022
View reviewed changes

@salimbraksa salimbraksa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both WordPress and Jetpack apps work as expected. LGTM! 🚀

@twstokes
twstokes force-pushed the enhancement/reader-scroll-to-top branch from af52fa8 to 8d4f760 Compare December 13, 2022 22:43
@twstokes twstokes modified the milestones: 21.5, 21.4 Dec 13, 2022
@twstokes

twstokes commented Dec 13, 2022

Copy link
Copy Markdown
Contributor Author

Squeezing this onto 21.4 since the release branch hasn't been cut yet. Auto-merge enabled.

@twstokes
twstokes enabled auto-merge December 13, 2022 22:44
@twstokes
twstokes merged commit 2020110 into trunk Dec 13, 2022
@twstokes
twstokes deleted the enhancement/reader-scroll-to-top branch December 13, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@salimbraksa salimbraksa salimbraksa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@twstokes twstokes

Labels

Reader

Projects

None yet

Milestone

21.4

Development

Successfully merging this pull request may close these issues.

Reader: Tapping the icon/tab should scroll to top

3 participants

@twstokes @wpmobilebot @salimbraksa