Repository navigation
Account Settings Primary Site: show URL if site has no name - #11577
Merged
Merged
Conversation
danielebogo
reviewed
Apr 29, 2019
danielebogo
approved these changes
Apr 29, 2019
danielebogo
left a comment
danielebogo
left a comment
Contributor
There was a problem hiding this comment.
Hey @ScoutHarris well done with this! I tested it as you wrote and it worked perfectly!
I left one small comment but feel free to skip it 😊
designsimply
reviewed
May 8, 2019
designsimply
left a comment
designsimply
left a comment
Contributor
There was a problem hiding this comment.
👍 LGTM! I'm just dropping by to add a screenshot after testing this with 12.4 beta:
Tested with WP Internal 12.4.0.20190505 on iPhone 6S iOS 12.2.
Contributor
|
I spoke too soon! Further beta testing revealed that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5884
In Account Settings > Primary Site, if the site has no name, the site URL will now be displayed.
To test:
Update release notes:
RELEASE-NOTES.txt.