Repository navigation
Notifications: Mark as unread - #11573
Merged
Merged
Conversation
danielebogo
reviewed
Apr 26, 2019
| return [] | ||
| } | ||
| let isRead = note.read | ||
|
|
Contributor
There was a problem hiding this comment.
What do you think if Notification can have a readonly property named isRead?In that way we can use notice.isRead to read the value without updating the data model.
Contributor
Author
There was a problem hiding this comment.
I think that could make sense, although I only created this local variable because I thought it was slightly more readable in this case. I'll leave it for this PR, but it's something we could consider if we need it elsewhere :) Thanks!
danielebogo
approved these changes
Apr 26, 2019
danielebogo
left a comment
danielebogo
left a comment
Contributor
There was a problem hiding this comment.
Thanks @frosty ! Well done with this! I left one comment but feel free to skip it. The test worked as you described even on the iPad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to mark notifications as unread. Swipe left-to-right on a read notification to mark unread.
To test:
Update release notes:
RELEASE-NOTES.txt.