Repository navigation
Improvements on Category managment feature - #17652
Merged
Merged
Conversation
Contributor
Author
|
This PR makes the changes for the Manage categories features ready for Production. Although some known issues/improvements(Listed in the Parent issue #16058) can be made, I feel those changes are not blockers. Since this feature has been requested for so long, I feel like we should release the feature and make improvements later on. I also would like to
Let me know your thoughts. |
AjeshRPai
marked this pull request as ready for review
December 9, 2022 12:18
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 48d9e69 | |
Generated by 🚫 dangerJS |
irfano
approved these changes
Dec 9, 2022
irfano
left a comment
irfano
left a comment
Member
There was a problem hiding this comment.
LGTM! 👍🏻
Thanks for handling the Hilt migration for these screens; we are one step closer to removing Dagger. 🎉
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 48d9e69 | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #16058
This PR has the following changes
To test:
Note: The Add/Edit/Delete category is already tested and merged with the PR (#17627). One more round of checking is needed for Regression issues if any
Verify that the Category management feature works as expected
Make sure that the Category management feature is visible in remote features
manage categoriesflag is visiblecc: @zwarm For visibility.
Regression Notes
Potential unintended areas of impact
Add/Edit/Delete category doesn't work as expected
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual tests
What automated tests I added (or what prevented me from doing so)
Units tests
PR submission checklist:
RELEASE-NOTES.txtif necessary.