Skip to content

ci: Improve release script - #163

Merged
dcalhoun merged 2 commits into
trunkfrom
ci/improve-release-script
Aug 4, 2025
Merged

ci: Improve release script#163
dcalhoun merged 2 commits into
trunkfrom
ci/improve-release-script

Conversation

@dcalhoun

@dcalhoun dcalhoun commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What?

  • Log correct version during dry runs
  • Skip publishing GitHub Releases for pre-releases

Why?

  • Improve the accuracy and usefulness of the dry runs
  • Enable creating frequent pre-releases during ongoing development, without
    generating unnecessary noise from published GitHub Releases

How?

  • Utilize Node.js semver package for calculating target version for dry runs
  • Disable GitHub Release publishing for pre-releases

Testing Instructions

Temporarily disable branch checks while testing:

Disable checks diff 

diff --git a/bin/release.sh b/bin/release.sh
index 4dabb97..9c1c651 100755
--- a/bin/release.sh
+++ b/bin/release.sh
@@ -355,8 +355,8 @@ main() {
     # Pre-flight checks
     print_status "Running pre-flight checks..."
     check_dependencies
-    check_branch
-    check_working_directory
+    # check_branch
+    # check_working_directory
     print_success "Pre-flight checks passed"
     echo

Perform dry runs with various release types to ensure the logged version is
correct.

make release DRY_RUN=true

Accessibility Testing Instructions

N/A, no user-facing changes.

Screenshots or screencast

N/A, no user-facing changes.

dcalhoun added 2 commits August 1, 2025 18:22
@dcalhoun
ci: Correct release script dry run version
11fbd88 
Ensure the correct version is calculated when performing a dry run.
@dcalhoun
ci: Release script skips publishing GitHub Releases for pre-releases
858598e 
This reduces unnecessary noise for pre-releases that are created
frequently for quick integration during active development between
releases.
@dcalhoun dcalhoun added the [Type] Build Tooling Issues or PRs related to build tooling label Aug 1, 2025
@dcalhoun
dcalhoun marked this pull request as ready for review August 1, 2025 22:49
@dcalhoun
dcalhoun requested a review from nbradbury August 1, 2025 22:50
@nbradbury nbradbury self-assigned this Aug 4, 2025
nbradbury
nbradbury approved these changes Aug 4, 2025
View reviewed changes

@nbradbury nbradbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with several VERSION_TYPEs and all good :shipit:

@dcalhoun
dcalhoun merged commit a5fe19a into trunk Aug 4, 2025
@dcalhoun
dcalhoun deleted the ci/improve-release-script branch August 4, 2025 13:56
jkmassel added a commit that referenced this pull request Aug 12, 2026
@jkmassel
build(deps): bump vulnerable dev dependencies to clear security advis…
38ef540 
…ories

Resolves 29 Dependabot advisories in the dev dependency tree. None of
these packages ship in the iOS/Android app bundle -- they are build,
lint, and local-WP (`@wordpress/env`) tooling.

In-range bumps:
- `vite` 8.0.5 -> 8.2.1 (direct devDep; floor raised to `^8.0.16`) #134 #135
- `shell-quote` -> 1.10.0 (critical #133) #165
- `fast-uri` -> 3.1.5 #163 #164 #179 #206 #207
- `js-yaml` -> 3.15.1 / 4.3.1 #157 #158 #167 #168 #200 #201
- `brace-expansion` #160 #166, `immutable` #161 #162, `tmp` #131,
  `fast-xml-builder` #122 #123, `simple-git` #119,
  `@babel/plugin-transform-modules-systemjs` #126

Scoped `overrides` (parents exact-pinned the vulnerable version):
- `ws` -> 8.21.0, keeping 7.5.13 for `react-devtools-core` #138 #153
- `qs` -> 6.15.2 under `@wordpress/env` #130
- `minimatch` -> 9.0.9 under `@typescript-eslint/typescript-estree` #65
- `@babel/core` -> 7.29.7 under `@wordpress/babel-preset-default` #154

Not addressed here: `electron` (33 alerts) and its bundled `got` (#33)
are pinned by `react-devtools@7.0.1` -- already the latest, and npm's
only "fix" is a breaking downgrade to `react-devtools@1.0.5`.
Runtime-scope advisories (`seroval`, `nanoid`, `postcss`, `showdown`,
`uuid`) are out of scope for a dev-only bump.

Verified: `npm run test:unit` (202 passing) and `npm run build` green.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbradbury nbradbury nbradbury approved these changes

Assignees

@nbradbury nbradbury

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcalhoun @nbradbury