This repository was archived by the owner on Jul 6, 2025. It is now read-only.
Avoid SPB render error by tweaking 'allowed' funding methods' empty value #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue A change in a recent release of PayPal's checkout.js is incompatible with the null value we were passing, breaking the rendering of the buttons – passing undefined as an alternative works fine.
allendav
approved these changes
Feb 3, 2019
|
@dechov, how soon should this show up in user's dashboards as an available update? |
Contributor
Author
|
@thesacredpath Should be up in the next 10-20 minutes. |
|
Thanks a bunch. I'll let the user know. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #527
A change in a recent release of PayPal's checkout.js is incompatible with the
nullvalue we were passing topaypal.Button.renderfor theallowedfunding methods, breaking the rendering of the buttons. Passingundefinedas an alternative works fine.Can test by loading the Cart page with Smart Payment Buttons and vertical layout enabled: in this branch the buttons should render normally, while in
masterthere should be no buttons and a browser console error.Edit: behavior can also be confirmed on PayPal Checkout's demo page:
allowed: nulldoesn't work, butallowed: undefineddoes.This change brings the render call closer in line with not including the unneeded property at all (i.e. only
disallowedis supported for vertical layout) – it is a minimal fix to solve the urgent issue.