[Woo POS][Local Catalog][Bug] Invoke DB query on IO dispatcher
#14904
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiuelson
changed the base branch from
trunk
to
woomob-1564-woo-poslocal-catalog
There was a problem hiding this comment.
Pull Request Overview
This PR refactors WooPosIsLocalCatalogVariationsEndpointAvailable to execute on the IO dispatcher by making its invoke() function a suspend function and adding CoroutineDispatchers dependency. This ensures that version checking operations are performed on the appropriate background thread.
- Made
WooPosIsLocalCatalogVariationsEndpointAvailable.invoke()a suspend function with IO dispatcher context - Added
CoroutineDispatchersparameter to the class constructor - Updated test to provide test dispatchers when constructing the class
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WooPosIsLocalCatalogVariationsEndpointAvailable.kt | Converted invoke function to suspend, added IO dispatcher wrapping, and injected CoroutineDispatchers dependency |
| WooPosIsLocalCatalogSupportedTest.kt | Updated test setup to provide testDispatchers to the WooPosIsLocalCatalogVariationsEndpointAvailable constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...oocommerce/android/ui/woopos/localcatalog/WooPosIsLocalCatalogVariationsEndpointAvailable.kt
Show resolved
Hide resolved
samiuelson
commented
Nov 5, 2025
| import javax.inject.Inject | ||
|
|
||
| class WooPosIsLocalCatalogVariationsEndpointAvailable @Inject constructor( | ||
| private val getWooVersion: GetWooCorePluginCachedVersion, |
There was a problem hiding this comment.
getWooVersion internally queries DB on the main thread.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
samiuelson
added
category: performance
samiuelson
added
the
status: do not merge
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
1 task
samiuelson
removed
the
status: do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
WooPosIsLocalCatalogVariationsEndpointAvailableto execute on the IO dispatcher by making itsinvoke()function a suspend function. This ensures that version checking operations are performed on the background thread, because internally they query the DB.💡 Don't merge until target is
trunkTest Steps
Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.