Remove unused Zendesk UI files #14902
Open
+0
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
The Zendesk layout override files are no longer needed and have been removed.
irfano
force-pushed
the
remove-unused-zendesk-ui-files
branch
from
e11141b to
a169b4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing the
com.zendesk:supportdependency PR, I had to updatezs_activity_request_list_scene_empty.xml. I noticed that this file is no longer used in the app since we don’t use the Zendesk UI anymore, we only use the Zendesk API to create tickets inSupportRequestFormActivity. In this PR PR I removed unused Zendesk UI layout files.Test Steps
There isn’t a test scenario. Just confirm that these files are truly not being used in the app.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.