Repository navigation
Conversation
This was referenced Oct 21, 2026
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
WordPress 7.2 skips deprecated two-hyphen IDs on Interactivity API lifecycle directives, leaving variation validation, galleries, thumbnail overflow, Mini-Cart hydration, and filter synchronization callbacks inactive. Switch those IDs to the supported three-hyphen syntax, restore the deprecated Products Query variation by subscribing to the
core/editorstore its selectors already read, and update editor test selectors for the WordPress 7.2 controls. Add post-editor regression coverage while preserving the original Site Editor inheritance-toggle test.The directive behavior changed in Gutenberg PR #84098; the supported syntax was announced in the WordPress 6.9 Interactivity API developer note. The affected IDs were added across earlier WooCommerce changes, including #60113, #60274, #63014, #64586, and #65622.
For the Product Query selector/subscription mismatch: Bug introduced in PR #60541. The post-editor registration is also guarded so it cannot overwrite the Site Editor's template-specific variation attributes.
Compatibility: no public signatures, hooks, saved block attributes, or variation names change. The directive syntax is supported on the currently supported WordPress versions; editor registration now observes the same store as its selectors. This affects shopper-facing add-to-cart behavior and editor registration timing, so it is marked
impact: highand requires an independent human review.Investigated from the WordPress 7.2 CI failure.
Screenshots or screen recordings:
Existing behavior and controls are restored; no visual design changes.
How to test the changes in this Pull Request:
Test with WordPress 7.2 beta 1 and repeat with WordPress 7.1, a block theme, and WooCommerce sample products. Build the blocks assets before testing.
In Appearance > Editor, open the Product Catalog template and select an existing Products (Deprecated) block. If necessary, insert the variation from the browser console:
Confirm Inherit query from template is visible. Disable it and confirm Advanced Filters becomes available; enable it again and confirm those filters are hidden.
In a new post, insert the same variation using the console snippet. Confirm Advanced Filters is available and Inherit query from template is hidden.
On a variable product using the Add to Cart + Options block, try adding it without selecting required options, then select a valid variation and add it. Confirm validation and add-to-cart work.
With Product Gallery on a variable product, change and clear the selected variation. Repeat with the classic Add to Cart Form. Confirm the gallery updates and restores the parent images. For a product with many images, confirm thumbnails scroll and the final thumbnail is reachable.
Place two Product Filters blocks targeting the same collection. Apply and remove filters in either instance and confirm both stay synchronized. Check filter chip colors, overlay scrolling, and that the Mini-Cart remains visible after client-side navigation.
Run the focused block E2E tests for product-collection inspector controls, attribute-filter style controls, and accessing the Checkout template from its page. Confirm they pass on both WordPress versions.
Testing that has already taken place:
wp-env, PHP 8.3, block theme, WooCommerce sample data, WordPress 7.1 and 7.2 beta 1.lint:php:changesandlint:changes:branchcompleted successfully; PHP checks are clean. Branch ESLint reports four existing warnings on unchanged lines in the Product Collection page object and Attribute Filter fixture.lint:jscompleted with zero errors and existing warnings. The changed Product Query source and new regression test lint cleanly.git diff --checkis clean.Milestone
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment
Created manually.
Use of AI Tools
Codex assisted with implementation, regression coverage, and local validation. Independent human review is pending.