Skip to content

Conversation

@bor0
Copy link
Member

@bor0 bor0 commented Nov 11, 2025

This reverts commit d6251b0.
This reverts commit 78d312a.

Let's see if we need to bring these back, together with a fix (TBD).

This reverts commit d6251b0.

This reverts commit 78d312a.
@bor0 bor0 added this to the 10.3.0 milestone Nov 11, 2025
@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@ralucaStan
Copy link
Contributor

@bor0 I pushed a fix that fixed the E2E test failures.
I also created a fix to target trunk #61923

The reason behind the failures was this change https://core.trac.wordpress.org/ticket/63887
It might be that they will modify the print_translations and our changes won't be needed in the Mini-Cart block.

We can wait a couple of days if you want, but I think the change can be kept on our end, even if the Core change is reverted. The Woo 10.4 feature freeze in on Monday.

@bor0
Copy link
Member Author

bor0 commented Nov 11, 2025

@ralucaStan thanks.

I think the change can be kept on our end, even if the Core change is reverted

Will imploding on \n work with WP < 6.9, or do we want to do it conditionally depending on the WP core version?

@bor0 bor0 changed the title Revert "Disable translations test" Revert "Disable translations test" and fix mini-cart block translations Nov 11, 2025
@ralucaStan
Copy link
Contributor

Will imploding on \n work with WP < 6.9, or do we want to do it conditionally depending on the WP core version?

It will work with all versions. It's a minor change that adds a new line after translations code when it gets concatenated. It doesn't make sense to check for WordPress versions IMO

@bor0 bor0 merged commit 0319a92 into release/10.3 Nov 12, 2025
63 checks passed
@bor0 bor0 deleted the bring-back-translations-tests branch November 12, 2025 11:38
@github-actions github-actions bot added the metric: feature freeze exception A tracking label for PRs that were merged after the feature freeze. label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

focus: e2e tests Issues related to e2e tests metric: feature freeze exception A tracking label for PRs that were merged after the feature freeze. plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants